Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/adapter lift request qos #930

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

luca-della-vedova
Copy link
Member

What's new

Ported from deploy/hammer, make the lift request qos transient local, having this publisher volatile and the subscription on rmf_ros2 transient local means communication does not take place and the lift request widget does not actually work.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

I tested this locally and without the fix the widget doesn't work, with it requests are respected.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.48%. Comparing base (7dfbbca) to head (62c5ba3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   50.48%   50.48%           
=======================================
  Files         283      283           
  Lines        7179     7179           
  Branches      981      981           
=======================================
  Hits         3624     3624           
  Misses       3407     3407           
  Partials      148      148           
Flag Coverage Δ
api-server 78.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronchongth aaronchongth merged commit 300b34e into main Apr 10, 2024
2 checks passed
@aaronchongth aaronchongth deleted the luca/adapter_lift_request_qos branch April 10, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants