Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: render optimizations #98

Merged
merged 17 commits into from
Sep 4, 2020
Merged

pref: render optimizations #98

merged 17 commits into from
Sep 4, 2020

Conversation

koonpeng
Copy link
Collaborator

@koonpeng koonpeng commented Sep 3, 2020

aka the great memoization, the panel and schedule visualizer components are memoized to avoid rendering when nothing changed.

performance metrics:

before:
image

after:
image

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0eddfc9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #98   +/-   ##
=========================================
  Coverage          ?   58.76%           
=========================================
  Files             ?       67           
  Lines             ?     1734           
  Branches          ?      360           
=========================================
  Hits              ?     1019           
  Misses            ?      715           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eddfc9...f4b79c9. Read the comment docs.

Copy link
Collaborator

@matiasbavera matiasbavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feels way smoother now. Times improved drastically

src/components/app.tsx Show resolved Hide resolved
src/util/react-helpers.ts Show resolved Hide resolved
@koonpeng koonpeng merged commit bd7e3b7 into master Sep 4, 2020
@koonpeng koonpeng deleted the perf/render-optimizations branch September 4, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants