Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick linking time fix to Humble #356

Merged
merged 2 commits into from
May 24, 2024

Conversation

luca-della-vedova
Copy link
Member

Cherry pick of #297 to humble branch.
This came up as part of open-rmf/rmf_ci_templates#10, moving from lld to ld in our action caused the humble branches that don't have the fix to timeout on linking.

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Co-authored-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
@luca-della-vedova
Copy link
Member Author

While CI is running, note that I fully expect rolling / jammy to fail going forward, I'm happy to remove it if we don't want the noise

@mxgrey
Copy link
Contributor

mxgrey commented May 24, 2024

I'm happy to remove it if we don't want the noise

I think it makes perfect sense to remove rolling for this branch. We don't care how the humble branch does against rolling anyway.

Signed-off-by: Luca Della Vedova <[email protected]>
@luca-della-vedova luca-della-vedova merged commit 3c20723 into humble May 24, 2024
3 checks passed
@luca-della-vedova luca-della-vedova deleted the luca/cherry_pick_linking_time branch May 24, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants