Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update the Nigerian Pizza description #76

Merged
merged 5 commits into from
May 13, 2024

Conversation

madefromjames
Copy link
Contributor

@madefromjames madefromjames commented May 1, 2024

Description

This PR adds the feature of enhancing Nigeria's pizza recipe.

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 📝 Documentation Update

Related Tickets & Documents

Closes #77

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

Partying Face

@madefromjames madefromjames requested a review from a team May 1, 2024 22:24
@madefromjames madefromjames changed the title Enhanced description of Nigerian Pizza #32 Enhanced description of Nigerian Pizza May 2, 2024
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @madefromjames,

Thank you for your contribution! ✨

I have a little review here for you to fix.

Also, please address the things below:

  • Change the PR title to be more descriptive to your changes. For example, "Feature: Update the Nigerian Pizza description".

  • In the "Related Tickets and Documents" section, please link to your issue number, which is Feature: Update Nigerian Pizza description #77. You can see the issue number right beside your issue title, as in the screenshot below. And please add the word "Closes" before the issue number.

    Screenshot 2024-05-02 090457

Please let me know if you have any questions.

Thank you! 😊

pizza-recipes.md Outdated Show resolved Hide resolved
@madefromjames madefromjames changed the title Enhanced description of Nigerian Pizza Feature: Update the Nigerian Pizza description May 2, 2024
@madefromjames
Copy link
Contributor Author

madefromjames commented May 2, 2024

Hey @madefromjames,

Thank you for your contribution! ✨

I have a little review here for you to fix.

Also, please address the things below:

  • Change the PR title to be more descriptive to your changes. For example, "Feature: Update the Nigerian Pizza description".
  • In the "Related Tickets and Documents" section, please link to your issue number, which is Add a pizza Recipe! (Please Keep This Issue Open) #77. You can see the issue number right beside your issue title, as in the screenshot below. And please add the word "Closes" before the issue number.
    Screenshot 2024-05-02 090457

Please let me know if you have any questions.

Thank you! 😊

Hi @adiati98 I appreciate your follow-up with me, I have linked the issue number.
image
I have also committed changes to the header Nigeria Pizza
Please let me know what more needs to be done.

@madefromjames madefromjames mentioned this pull request May 4, 2024
2 tasks
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @madefromjames,

We don't want to modify any other files than the pizza-recipes.md here.

I have a review here for you to fix.

Please let me know when you're done. Thank you. 🙂

package-lock.json Outdated Show resolved Hide resolved
This reverts commit 88cea5d.

Enhanced description of Nigerian Pizza and revert json file
…izza-verse into feature/add-pizza-recipe

Enhanced description of Nigerian Pizza and revert json file
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @madefromjames!

thanks gif

@adiati98 adiati98 merged commit a456ac4 into open-sauced:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Update Nigerian Pizza description
3 participants