Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port FSRS-5 from py-fsrs #12

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: port FSRS-5 from py-fsrs #12

wants to merge 8 commits into from

Conversation

brainwo
Copy link
Contributor

@brainwo brainwo commented Aug 29, 2024 •
edited
Loading

Port from open-spaced-repetition/py-fsrs@1b4cbe4...a200a78

Status:

  • FSRS algorithm update to match the latest py-fsrs algorithm (a200a78)
    • fsrs_base.dart
    • models.dart
    • Pass all the test cases
  • Test case updates
    • Scheduling algorithm
    • Models
    • JSON serialization/deserialization test cases
  • Documentations for dart doc

Closes #10

@brainwo brainwo changed the title Port FSRS5 from py-fsrs feat: port FSRS5 from py-fsrs Aug 29, 2024
@brainwo
Copy link
Contributor Author

brainwo commented Aug 29, 2024

I think I want to add documentations alongside with this pull request. Which means #8 could be blocking this PR.

@sonbui00
Copy link
Member

@brainwo No problem. If you require #8 on this, just put it on.

@brainwo brainwo changed the title feat: port FSRS5 from py-fsrs feat: port FSRS-5 from py-fsrs Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FSRS-5 port
2 participants
@brainwo @sonbui00