Fix/inconsistent outlier filter (#108)

open-spaced-repetition · Apr 21, 2024 · 17d6aef · 17d6aef
1 parent 37ece5e
commit 17d6aef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "FSRS-Optimizer"
-version = "4.28.0"
+version = "4.28.1"
 readme = "README.md"
 dependencies = [
     "matplotlib>=3.7.0",

diff --git a/src/fsrs_optimizer/fsrs_optimizer.py b/src/fsrs_optimizer/fsrs_optimizer.py
@@ -426,11 +426,12 @@ def remove_outliers(group: pd.DataFrame) -> pd.DataFrame:
         count = grouped_group.loc[i, ("y", "count")]
         delta_t = grouped_group.loc[i, "delta_t"].values[0]
         if has_been_removed + count >= max(total * 0.05, 20):
-            break
-        else:
             if count < 6 or delta_t > (100 if group.name[0] != "4" else 365):
                 group.drop(group[group["delta_t"] == delta_t].index, inplace=True)
                 has_been_removed += count
+        else:
+            group.drop(group[group["delta_t"] == delta_t].index, inplace=True)
+            has_been_removed += count
     return group