Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Revlog->FSRSItem conversion #13

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Simplify Revlog->FSRSItem conversion #13

merged 13 commits into from
Aug 23, 2023

Commits on Aug 22, 2023

  1. Add comment about the required file to the test; move into test module

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    35c2047 View commit details
    Browse the repository at this point in the history

  2. Add English translations to extract_time_series_feature()

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0882401 View commit details
    Browse the repository at this point in the history

  3. review_kind = 4 is excluded in SQL query

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9ef7059 View commit details
    Browse the repository at this point in the history

  4. Shift review_kind=3 check into SQL

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f7fc0b5 View commit details
    Browse the repository at this point in the history

  5. Detect non-learning starts earlier 

    .retain() is fairly expensive, as it requires shuffling data about; better
to filter the material before the array is created
    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a878732 View commit details
    Browse the repository at this point in the history

  6. Add some more checks

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9ea8610 View commit details
    Browse the repository at this point in the history

  7. Convert Vec<Revlog> directly to FSRSItem

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    128d190 View commit details
    Browse the repository at this point in the history

  8. Review->FSRSReview

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    62f175c View commit details
    Browse the repository at this point in the history

  9. Make label/delta_t the same type as FSRSReview; do conversion later

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6a95734 View commit details
    Browse the repository at this point in the history

  10. Add a test to check tensor conversion

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a20feda View commit details
    Browse the repository at this point in the history

  11. Fix clippy lints

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d327628 View commit details
    Browse the repository at this point in the history

  12. Move current review into the list of reviews, instead of storing sepa… 

    …rately
    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    781896e View commit details
    Browse the repository at this point in the history

  13. Remove some unused clones

    @dae
    dae committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    306a2ea View commit details
    Browse the repository at this point in the history