Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BCELoss #18

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add BCELoss #18

merged 1 commit into from
Aug 22, 2023

Conversation

L-M-Sherlock
Copy link
Member

No description provided.

@L-M-Sherlock L-M-Sherlock requested a review from dae August 22, 2023 06:51
@L-M-Sherlock L-M-Sherlock linked an issue Aug 22, 2023 that may be closed by this pull request
[TODO] fix: BCELoss #17
Closed
dae
dae approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@dae dae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the math, but the Rust code looks fine. In the long run we may want to remove the dbg/info printing, but that's not urgent.

@L-M-Sherlock L-M-Sherlock merged commit 938cc92 into main Aug 22, 2023
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Add-BCELoss branch August 22, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae dae dae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TODO] fix: BCELoss
2 participants
@L-M-Sherlock @dae