-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python bindings #19
Python bindings #19
Conversation
If we integrate FSRS into Anki client, should we still need to integrate the training module into the add-on? |
I'm afraid I don't think this PR is a good idea.
I would recommend waiting until the API gets decided on, and this gets integrated into Anki's Rust library - then users will be able to access it directly and will not even need an add-on. If you did still want to expose it separately in Python for some reason, once the API is determined, you could do so by creating a separate Rust crate that exposes this crate's public API, like how Anki has a normal Rust crate and a separate pyo3 crate. |
Oh are we integrating it into Anki itself? I'd always assumed the add-on was the goal. |
I quickly added it into the addon as a proof of concept.
If you want to test it clone it recursively then run make. Again if this is going to be added into anki there isnt much point in this. |
Yep, the plan is to integrate this crate in Anki. |
Sounds great to me 👍. |
Hopefully with this it will make it easier to integrate into the add-on.
Requires Maturin.
Allows you to call train from python as shown in py/test.py.
Run
Or manually create a .venv and run
maturin develop
Should run as if it was called from rust