Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the latest Burn and pin dependencies #33

Merged
merged 5 commits into from
Aug 26, 2023
Merged

Update to the latest Burn and pin dependencies #33

merged 5 commits into from
Aug 26, 2023

Commits on Aug 26, 2023

  1. Add Cargo.lock 

    The presence of a lock file doesn't affect the versions that other crates
will use, and it ensures that tests in CI are reproducible. Rust currently
recommends not checking it in for libraries, but this appears to be about
to change:
rust-lang/cargo#8728
    @dae
    dae committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    053dd00 View commit details
    Browse the repository at this point in the history

  2. Update to the latest Burn; pin to a specific commit

    @dae
    dae committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    ca9ed42 View commit details
    Browse the repository at this point in the history

  3. Silence a clippy warning 

    https://rust-lang.github.io/rust-clippy/master/index.html#/single_range_in_vec_init
was triggering for lines like

  let rating = ratings.clone().slice([i..i + 1]).transpose();

I think the warning probably doesn't apply for this API.
    @dae
    dae committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    b40c62d View commit details
    Browse the repository at this point in the history

  4. Fix a clippy warning

    @dae
    dae committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    2367a42 View commit details
    Browse the repository at this point in the history

  5. Pin the Rust version 

    Allowing it to float will lead to future clippy breakages, as clippy
routinely adds extra checks in new updates.
    @dae
    dae committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    0253b9f View commit details
    Browse the repository at this point in the history