Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemConv generator should differentiate int and double type in YAML model and generated files #13

Closed
arminru opened this issue Oct 15, 2020 · 0 comments · Fixed by #30
Closed

SemConv generator should differentiate int and double type in YAML model and generated files #13

arminru opened this issue Oct 15, 2020 · 0 comments · Fixed by #30
Assignees
@thisthat
Labels
semconv Related to the semantic convention generator.

Comments

@arminru
Copy link
Member

arminru commented Oct 15, 2020

From open-telemetry/opentelemetry-specification#1096:

YAML model for attributes seems to only have number type. But we have int or double as possible attribute types.

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/common/common.md#attributes
https://github.com/open-telemetry/opentelemetry-specification/blob/master/semantic_conventions/syntax.md
@arminru arminru mentioned this issue Oct 15, 2020
Closed
@arminru arminru changed the title SemConv MD generator should differentiate int and double type in YAML model and generated MD SemConv generator should differentiate int and double type in YAML model and generated files Oct 15, 2020
@thisthat thisthat mentioned this issue Oct 22, 2020
Merged
@Oberon00 Oberon00 mentioned this issue Nov 2, 2020
Closed
@Oberon00 Oberon00 mentioned this issue Dec 4, 2020
Open
@Oberon00 Oberon00 mentioned this issue Feb 10, 2021
Merged
@thisthat thisthat mentioned this issue Feb 23, 2021
Merged
@Oberon00 Oberon00 added the semconv Related to the semantic convention generator. label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisthat thisthat

Labels
semconv Related to the semantic convention generator.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add int and double types. Small bugfixes. thisthat/build-tools
3 participants
@Oberon00 @thisthat @arminru