Add int and double types. Small bugfixes. #30
Conversation
semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
Show resolved
Hide resolved
semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
Show resolved
Hide resolved
| "string", | ||
| "string[]", | ||
| "number", | ||
| "number[]", | ||
| "int", | ||
| "int[]", | ||
| "double", | ||
| "double[]", | ||
| "boolean", | ||
| "boolean[]", |
There was a problem hiding this comment.
If you make the dictionary in type_mapper a (static) constant, you can just do if attr_type in that_dict (in checks the keys with a dictionary right-hand side)
|
@open-telemetry/specs-approvers Can we merge this? |
There was a problem hiding this comment.
@thisthat I think this is our first breaking change with the generator. Could you please either add a changelog section in the README or a separate file for tracking these changes? Users will have to update their YAML files accordingly.
| @@ -275,17 +282,21 @@ def is_simple_type(attr_type: str): | |||
| return attr_type in ( | |||
| "string", | |||
| "string[]", | |||
| "number", | |||
| "number[]", | |||
| "int", | |||
There was a problem hiding this comment.
will it break all active PRs? Maybe keep number, than fix yamls and then remove number?
There was a problem hiding this comment.
This won't break active PRs until we bump the tool version in the Github action
Co-authored-by: Armin Ruech <[email protected]>
This was recently introduced in open-telemetry/build-tools#30. Fixes open-telemetry#1096.
This PR fixes #13
FYI @anuraaga :)