Add scope semantic conventions as a type #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
reviewed
Jul 29, 2022
semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py
Show resolved
Hide resolved
arminru
reviewed
Jul 29, 2022
joaopgrassi
reviewed
Jul 29, 2022
semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py
Show resolved
Hide resolved
semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py
Show resolved
Hide resolved
Co-authored-by: Joao Grassi <[email protected]>
dashpole
force-pushed
the
span_attrs
branch
5 times, most recently
from
17ac5cd
to
dff679d
Compare
joaopgrassi
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Looks good to me! Pinging @Oberon00 as he has more experience with the tool in general.
semantic-conventions/src/tests/semconv/templating/test_markdown.py
Outdated
Show resolved
Hide resolved
arminru
reviewed
Aug 2, 2022
semantic-conventions/src/tests/semconv/model/test_correct_parse.py
Outdated
Show resolved
Hide resolved
…n.py Co-authored-by: Joao Grassi <[email protected]>
arminru
approved these changes
Aug 2, 2022
dashpole
force-pushed
the
span_attrs
branch
4 times, most recently
from
298ede1
to
fdc3404
Compare
joaopgrassi
approved these changes
Aug 8, 2022
Oberon00
reviewed
Aug 8, 2022
semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py
Outdated
Show resolved
Hide resolved
Oberon00
approved these changes
Aug 8, 2022
arminru
approved these changes
Aug 8, 2022
|
What needs to be done to update this on my PR (so it passes tests)? open-telemetry/opentelemetry-specification#2702 |
|
@dashpole we need a new release/image of the tools and then update the makefile in the spec repo https://github.com/open-telemetry/opentelemetry-specification/blob/main/Makefile#L11. That should do it. |
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Aug 16, 2022
This unblocks #2702 by making the changes introduced in open-telemetry/build-tools#114 available for use. It also allows for more semantic conventions for scope attributes to be defined in the future (#2682). See https://github.com/open-telemetry/build-tools/releases/tag/v0.14.0.
ChengJinbao
added a commit
to ChengJinbao/opentelemetry-specification
that referenced
this pull request
Nov 16, 2022
This unblocks #2702 by making the changes introduced in open-telemetry/build-tools#114 available for use. It also allows for more semantic conventions for scope attributes to be defined in the future (#2682). See https://github.com/open-telemetry/build-tools/releases/tag/v0.14.0.
jsuereth
pushed a commit
to jsuereth/otel-semconv-test
that referenced
this pull request
Apr 19, 2023
This unblocks #2702 by making the changes introduced in open-telemetry/build-tools#114 available for use. It also allows for more semantic conventions for scope attributes to be defined in the future (#2682). See https://github.com/open-telemetry/build-tools/releases/tag/v0.14.0.
jsuereth
pushed a commit
to open-telemetry/semantic-conventions
that referenced
this pull request
May 11, 2023
This unblocks #2702 by making the changes introduced in open-telemetry/build-tools#114 available for use. It also allows for more semantic conventions for scope attributes to be defined in the future (#2682). See https://github.com/open-telemetry/build-tools/releases/tag/v0.14.0.
joaopgrassi
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Mar 21, 2024
This unblocks #2702 by making the changes introduced in open-telemetry/build-tools#114 available for use. It also allows for more semantic conventions for scope attributes to be defined in the future (#2682). See https://github.com/open-telemetry/build-tools/releases/tag/v0.14.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-specification#2682
Addresses this comment: open-telemetry/opentelemetry-specification#2702 (comment)
This adds "scope" as a semantic convention type.
cc @joaopgrassi