-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReceiverLoop
doesn't stop on cancelling context
#239
Comments
srikanthccv
added a commit
to srikanthccv/opamp-go
that referenced
this issue
Jan 13, 2024
tigrannajaryan
pushed a commit
that referenced
this issue
Jan 23, 2024
Here is test run that shows it doesn't stop without fix https://github.com/open-telemetry/opamp-go/actions/runs/7512286887/job/20452817400 Fixes #239
haoqixu
pushed a commit
to haoqixu/opamp-go
that referenced
this issue
Mar 7, 2024
Here is test run that shows it doesn't stop without fix https://github.com/open-telemetry/opamp-go/actions/runs/7512286887/job/20452817400 Fixes open-telemetry#239
haoqixu
pushed a commit
to haoqixu/opamp-go
that referenced
this issue
Mar 7, 2024
Here is test run that shows it doesn't stop without fix https://github.com/open-telemetry/opamp-go/actions/runs/7512286887/job/20452817400 Fixes open-telemetry#239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
opamp-go/client/internal/wsreceiver.go
Lines 44 to 62 in 62d8b60
The receiver loop here doesn't stop when the context is cancelled. The break out is reached only when there is an error from
receiveMessage
.The text was updated successfully, but these errors were encountered: