Explain in CONTRIBUTING.md that opamp-spec submodule is needed #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 76.11% 76.48% +0.37%
==========================================
Files 24 24
Lines 1834 1863 +29
==========================================
+ Hits 1396 1425 +29
Misses 326 326
Partials 112 112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mhausenblas
reviewed
Feb 21, 2023
tigrannajaryan
force-pushed
the
feature/tigran/contributing
branch
from
37dfdc4
to
31ec7de
Compare
mhausenblas
approved these changes
Feb 21, 2023
andykellr
approved these changes
Feb 22, 2023
andykellr
reviewed
Feb 22, 2023
The submodule is necessary for `make gen-proto` target. Also added a check in makefile to verify that the submodule is cloned.
tigrannajaryan
force-pushed
the
feature/tigran/contributing
branch
from
31ec7de
to
5394b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule is necessary for
make gen-prototarget.Also added a check in makefile to verify that the submodule is cloned.