Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.type instead of os.family #161

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Use os.type instead of os.family #161

merged 1 commit into from
Mar 20, 2023

Conversation

jlegoff
Copy link
Contributor

@jlegoff jlegoff commented Mar 20, 2023

The semantic conventions define os.type, but the examples use os.family. Let's follow the convention!

@jlegoff jlegoff requested a review from a team March 20, 2023 16:40
@tigrannajaryan tigrannajaryan enabled auto-merge (squash) March 20, 2023 16:54
@tigrannajaryan tigrannajaryan merged commit 06011e4 into open-telemetry:main Mar 20, 2023
@jlegoff jlegoff deleted the fix-os-type branch March 20, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlegoff @tigrannajaryan