Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added appropriate error message on package installation failure #197

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Added appropriate error message on package installation failure #197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d891422
Added appropriate error message on failure
phanidevavarapu Aug 31, 2023
fbd3921
PR comments
phanidevavarapu Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/internal/packagessyncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@

err = s.localState.UpdateContent(ctx, pkgName, resp.Body, file.ContentHash)
if err != nil {
return fmt.Errorf("cannot download file from %s: %v", file.DownloadUrl, err)
return fmt.Errorf("failed to install/update the package %s downloaded from %s: %v", pkgName, file.DownloadUrl, err)

Check warning on line 281 in client/internal/packagessyncer.go

View check run for this annotation

Codecov / codecov/patch

client/internal/packagessyncer.go#L281 

Added line #L281 was not covered by tests
}
return nil
}
Expand Down
Loading