Remove OnOpampConnectionSettingsAccepted callback #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to open-telemetry#261 I intentionally left undefined the blocking vs nonblocking requirement for the callback. I suggest that we refine this after we make implementations and settle on a particular behavior. A continuation of this PR is needed that implements steps 4 and 5 of the flow described here: open-telemetry#261
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 75.10% 75.06% -0.05%
==========================================
Files 25 25
Lines 1631 1628 -3
==========================================
- Hits 1225 1222 -3
Misses 295 295
Partials 111 111 ☔ View full report in Codecov by Sentry. |
andykellr
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #261
I intentionally left undefined the blocking vs nonblocking requirement for the callback. I suggest that we refine this after we make implementations and settle on a particular behavior.
A continuation of this PR is needed that implements steps 4 and 5 of the flow described here:
#261