fail if TopN is negative

open-telemetry · Oct 18, 2023 · 89cad5c · 89cad5c
1 parent d2a506c
commit 89cad5c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/pkg/stanza/fileconsumer/matcher/matcher.go b/pkg/stanza/fileconsumer/matcher/matcher.go
@@ -67,6 +67,10 @@ func New(c Criteria) (*Matcher, error) {
 		return nil, fmt.Errorf("'regex' must be specified when 'sort_by' is specified")
 	}
 
+	if c.OrderingCriteria.TopN < 0 {
+		return nil, fmt.Errorf("`top_n` must be a positive integer")
+	}
+
 	if c.OrderingCriteria.TopN == 0 {
 		c.OrderingCriteria.TopN = defaultOrderingCriteriaTopN
 	}

diff --git a/pkg/stanza/fileconsumer/matcher/matcher_test.go b/pkg/stanza/fileconsumer/matcher/matcher_test.go
@@ -98,6 +98,23 @@ func TestNew(t *testing.T) {
 			},
 			expectedErr: "compile regex: error parsing regexp: missing closing ]: `[a-z`",
 		},
+		{
+			name: "TopN is negative",
+			criteria: Criteria{
+				Include: []string{"*.log"},
+				OrderingCriteria: OrderingCriteria{
+					Regex: "[a-z]",
+					TopN:  -1,
+					SortBy: []Sort{
+						{
+							SortType: "numeric",
+							RegexKey: "key",
+						},
+					},
+				},
+			},
+			expectedErr: "`top_n` must be a positive integer",
+		},
 		{
 			name: "SortTypeEmpty",
 			criteria: Criteria{