[processor/transform] Metric conversion functions use datapoint context instead of metric context

[BinaryFissionGames]

Component(s)

processor/transform

Describe the issue you're reporting

The function convert_gauge_to_sum, convert_sum_to_gauge, convert_summary_sum_val_to_sum and convert_summary_count_val_to_sum all are using the datapoint context, but I'm not sure I understand why.

They all operate on the top-level "metric", so I think they should be using the metric context, since they should each run only once for each metric, and not once for each datapoint.

It seems like this was just retaining the old behavior before contexts were introduced, but I think these functions are actually better suited on the metric context.

[github-actions]

Pinging code owners:

• processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[TylerHelmuth]

At the time of their creation, which was during transformprocessor/OTTL infancy, we didn't have the concept of the metrics context, we only had spans, datapoints, and log records. You are correct that these are better suited for the metrics context.

[BinaryFissionGames]

That makes sense. Are we OK with changing these to be on the metrics context (with a feature flag, since it would be a breaking change)?

I'd be willing to take that on, if you think so.

[TylerHelmuth]

As long as we follow the feature gate deprecation process go for it.

[TylerHelmuth]

@BinaryFissionGames I would suggest waiting until #18822 is merged to start your work.

[BinaryFissionGames]

Got it, thanks for the heads up on that.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[evan-bradley]

The plumbing to handle this was added in #24446. convert_summary_sum_val_to_sum and convert_summary_count_val_to_sum will likely be deprecated sometime after #22853 is closed, but I think convert_gauge_to_sum and convert_sum_to_gauge could be updated to take advantage of this.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[evan-bradley]

@BinaryFissionGames are you still interested in working on this? It should be ready for implementation.

[BinaryFissionGames]

Sorry for the late response @evan-bradley - I don't think I'll be getting around to this anytime soon, so if anyone else has any interest in taking it, they should totally go for it.