Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move internal/golden to pkg/golden #28594

Closed
atoulme opened this issue Oct 24, 2023 · 2 comments · Fixed by #28636
Closed

Move internal/golden to pkg/golden #28594

atoulme opened this issue Oct 24, 2023 · 2 comments · Fixed by #28636
Labels
enhancement New feature or request

Comments

@atoulme
Copy link
Contributor

atoulme commented Oct 24, 2023

Component(s)

No response

Is your feature request related to a problem? Please describe.

I have found the internal/golden package useful and would like to draw more on it. Unfortunately, I cannot import it in my projects as it is internal.

Describe the solution you'd like

Move internal/golden to pkg/golden.

Describe alternatives you've considered

No response

Additional context

No response
@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Oct 24, 2023
@atoulme
Copy link
Contributor Author

atoulme commented Oct 24, 2023

@djaglowski Please let me know if you have an opinion on this.

@djaglowski
Copy link
Member

@atoulme, I've always hoped we'd do this eventually. I support.

@atoulme atoulme removed the needs triage New item requiring triage label Oct 25, 2023
@atoulme atoulme mentioned this issue Oct 26, 2023
Merged
djaglowski added a commit that referenced this issue Oct 27, 2023
@atoulme @djaglowski
[pkg/golden] internal/coreinternal/golden -> pkg/golden (#28636)
cd92432 
**Description:**
Move the golden package to pkg/golden so it can be available to
downstream projects.

**Link to tracking Issue:**
Fixes #28594

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
@djaglowski djaglowski mentioned this issue Oct 27, 2023
Merged
djaglowski added a commit that referenced this issue Oct 27, 2023
@djaglowski
[chore] Fix merge conflict with golden package move (#28662)
1f646ab 
This fixes a merge conflict between #28594 and #26475
@github-actions github-actions bot mentioned this issue Oct 31, 2023
Closed
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@atoulme @djaglowski @jmsnll
[pkg/golden] internal/coreinternal/golden -> pkg/golden (open-telemet…
f3c15c8 
…ry#28636)

**Description:**
Move the golden package to pkg/golden so it can be available to
downstream projects.

**Link to tracking Issue:**
Fixes open-telemetry#28594

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@djaglowski @jmsnll
[chore] Fix merge conflict with golden package move (open-telemetry#2…
daf7a31 
…8662)

This fixes a merge conflict between open-telemetry#28594 and open-telemetry#26475
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@atoulme @djaglowski @RoryCrispin
[pkg/golden] internal/coreinternal/golden -> pkg/golden (open-telemet…
9a788ec 
…ry#28636)

**Description:**
Move the golden package to pkg/golden so it can be available to
downstream projects.

**Link to tracking Issue:**
Fixes open-telemetry#28594

---------

Co-authored-by: Daniel Jaglowski <[email protected]>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@djaglowski @RoryCrispin
[chore] Fix merge conflict with golden package move (open-telemetry#2…
ba08b5f 
…8662)

This fixes a merge conflict between open-telemetry#28594 and open-telemetry#26475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pkg/golden] internal/coreinternal/golden -> pkg/golden atoulme/opentelemetry-collector-contrib
2 participants
@atoulme @djaglowski