-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Endpoint and Insecure on googlecloudpubsub exporter #29304
Comments
Is this needed outside of testing environments? If it's only for testing there are existing internal options for
opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter/config.go Lines 25 to 28 in 0a79aa8
Example usage in a test: opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter/exporter_test.go Lines 34 to 36 in 0a79aa8
Is this what you're looking for, or am I missing something? |
Pinging code owners for exporter/googlecloudpubsub: @alexvanboxel. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
yes @crobert-1 . that's exactly what I need. I'm making them public with some |
I'm not sure I understand the situation fully, do you need these member properties to be public? If the tests are being added to this repository and module, you'd have access to the private properties. |
I will expose the insecure field in both the receiver and the exporter (aligned with the other gRPC configurations in the collector) |
expose `Endpoint` and `Insecure` in configuration fixes: open-telemetry#29304
Fixed by #29740 |
…try#29740) **Description:** expose `Endpoint` and `Insecure` in configuration **Link to tracking Issue:** open-telemetry#29304 **Testing:** Adapted tests to use the new attributes **Documentation:** Added new attributes to documentation
Component(s)
No response
Is your feature request related to a problem? Please describe.
We are creating self-contained integration tests. While the pubsub receiver allows the endpoint and insecure configurations, the exporter does not.
Describe the solution you'd like
The ability to set the endpoint and insecure configuration options.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: