Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/loki] Refactor use of host.ReportFatalError #30580

Closed
Tracked by #30501
atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #30611
Closed
Tracked by #30501

[receiver/loki] Refactor use of host.ReportFatalError #30580

atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #30611
Assignees
@codeboten
Labels
bug Something isn't working receiver/loki

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024 •
edited
Loading

Component(s)

receiver/loki

Describe the issue you're reporting

Refactor to remove use of host.ReportFatalError, you can use settings.TelemetrySettings.ReportStatus(component.NewFatalErrorEvent(err)) instead.

See #30505 for an example.
@atoulme atoulme added the needs triage New item requiring triage label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Jan 16, 2024
Closed
Closed
@crobert-1 crobert-1 added bug Something isn't working and removed needs triage New item requiring triage labels Jan 16, 2024
@codeboten codeboten mentioned this issue Jan 16, 2024
Merged
@codeboten codeboten self-assigned this Jan 16, 2024
bogdandrutu pushed a commit that referenced this issue Jan 16, 2024
[chore] loki receiver ReportFatalError -> ReportStatus (#30611)
a3a5ea8 
Remove use of deprecated host.ReportFatalError

Linked to
#30501

Fixes #30580

Signed-off-by: Alex Boten <[email protected]>
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@cparkins
[chore] loki receiver ReportFatalError -> ReportStatus (open-telemetr…
f2a5ff1 
…y#30611)

Remove use of deprecated host.ReportFatalError

Linked to
open-telemetry#30501

Fixes open-telemetry#30580

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working receiver/loki
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] loki receiver ReportFatalError -> ReportStatus codeboten/opentelemetry-collector-contrib
3 participants
@atoulme @codeboten @crobert-1