Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/observer/dockerobserver] Remove deprecated use of host.ReportFatalError #30583

Closed
Tracked by #30501
atoulme opened this issue Jan 16, 2024 · 3 comments · Fixed by #31144
Closed
Tracked by #30501

[extension/observer/dockerobserver] Remove deprecated use of host.ReportFatalError #30583

atoulme opened this issue Jan 16, 2024 · 3 comments · Fixed by #31144
Labels

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024

Component(s)

extension/observer/dockerobserver

Describe the issue you're reporting

Describe the issue you're reporting

Refactor to remove use of host.ReportFatalError, you can use settings.TelemetrySettings.ReportStatus(component.NewFatalErrorEvent(err)) instead.

See #30505 for an example.

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added bug Something isn't working and removed needs triage New item requiring triage labels Jan 16, 2024
@codeboten
Copy link
Contributor

I don't see a call to host.ReportFatalError in this observer. Closing, please re-open if I'm mistaken

@atoulme
Copy link
Contributor Author

atoulme commented Jan 17, 2024

It's used here:

h.t.Fatalf("Receiver reported a fatal error: %v", err)

Granted, it's just an integration test, but should be possible to move off of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants