Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localhost feature gate on extension/healthcheck #30818

Closed
Tracked by #30702
mx-psi opened this issue Jan 29, 2024 · 3 comments · Fixed by #30992
Closed
Tracked by #30702

Use localhost feature gate on extension/healthcheck #30818

mx-psi opened this issue Jan 29, 2024 · 3 comments · Fixed by #30992

Comments

@mx-psi
Copy link
Member

mx-psi commented Jan 29, 2024

No description provided.

@mx-psi mx-psi mentioned this issue Jan 29, 2024
Closed
18 tasks
@mx-psi
Copy link
Member Author

mx-psi commented Jan 29, 2024

@dmitryax @bogdandrutu on open-telemetry/opentelemetry-collector/pull/2828 we changed this to 0.0.0.0. Do we want to revert this change?

@mx-psi
Copy link
Member Author

mx-psi commented Jan 29, 2024

Also cc @mwear @jpkrohling

@github-actions github-actions bot mentioned this issue Jan 30, 2024
Closed
@mx-psi mx-psi mentioned this issue Feb 1, 2024
Merged
@jpkrohling
Copy link
Member

Yes! Health check and monitoring ports are exactly the cases where we want to use local addresses (127.0.0.1) vs. broader ones (0.0.0.0)

mx-psi added a commit that referenced this issue Feb 1, 2024
@mx-psi
[chore][extension/health_check] Use component.UseLocalHostAsDefaultHo…
cdea2d5 
…st feature gate (#30992)

**Description:** Fixes #30818, see
#30818 (comment)
for historical context. I think we should still do it.

Also reorders the entries in the changelog to be in alphabetical order
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@mx-psi @cparkins
[chore][extension/health_check] Use component.UseLocalHostAsDefaultHo…
f9729e5 
…st feature gate (open-telemetry#30992)

**Description:** Fixes open-telemetry#30818, see
open-telemetry#30818 (comment)
for historical context. I think we should still do it.

Also reorders the entries in the changelog to be in alphabetical order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jpkrohling @mx-psi