-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/mdatagen] Provide config with all metrics disabled #30993
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I know this is moving to collector core soon, but I opted to open the issue and PR here for now and will move it over if/when needed. |
Sounds good to me, removing |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
Closing in favour of open-telemetry/opentelemetry-collector#10074 |
Component(s)
cmd/mdatagen
Is your feature request related to a problem? Please describe.
There are some scenarios where it would be nice to easily receive a metric builder config with all metrics disabled. (Example scenario in Additional Context)
Describe the solution you'd like
I would like to add a new function called
DefaultMetricsConfigAllDisabled
(or something to that effect) to the generation template that will provide a metric builder config with all metrics disabled.Describe alternatives you've considered
Currently the only way to do this is to get a default config and manually set all the metrics enabled fields to false, or to use reflection.
Additional context
I encountered a scenario in #30894 where this would have been useful. I would have liked to be able to provide a test where only 2 of the metrics in the config were enabled, but it would have been very repetitive to write disabling every other metric. This also applies to how I would have liked to provide fields on the
processscraper
config that might enable/disable groups of metrics for convenience.The text was updated successfully, but these errors were encountered: