[receiver/hostmetrics] Deprecate processesscraper #30894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates the processesscraper in favour of adding the functionality to the processscraper.
braydonk
force-pushed
the
deprecate_processes_scraper
branch
from
82dd1b4
to
4249401
Compare
This was referenced Feb 1, 2024
Since this receiver is in beta, I should not have directly been making a deprecation in this PR. Instead this PR will be focused on adding the functionality to the `processscraper` and provides a warning suggestion to the `processesscraper` instead of directly declaring it deprecated.
dmitryax
reviewed
Feb 1, 2024
receiver/hostmetricsreceiver/internal/scraper/processesscraper/processes_scraper.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go
Show resolved
Hide resolved
The guard in scrapeAndAppendSystemProcessesCreated metric was already covered by the record data point function.
* Add system.processes.* metrics to allowed metrics in duplicate metrics validation test * Change ctx arg to _ in certain functions * Change type name to Scraper in processesscraper fallback
Fixed a misname in the fallback build for aggregate process data, run gci on the aggregate_process files.
ChrsMark
reviewed
Feb 8, 2024
|
As discussed on the System Semantic Conventions SIG, we want to have a way to disable all metrics in particular group. It's needed if users don't have the |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR deprecates the
processesscraperin favour of adding the functionality to theprocessscraper.Link to tracking Issue:
#30895
Testing:
I wrote all testing with explanations in https://gist.github.com/braydonk/124f4242299a8cb03f44c55b056450e1
Documentation:
I added a note to the
hostmetricsreceiverREADME and generated new docs forprocessscraper.