-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/filestorage] - Provide an option to the user to create a directory for them #34939
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think this would be a useful feature. What would be the permissions on the created directory? Would |
@andrzej-stencel I think 0750 is a good default.
I think it would be sufficient to document that the default directory creation mode is |
Ok let's start with that. 👍 |
@andrzej-stencel can you assign this to me (or should we wait for @djaglowski to be back from vacation)? |
@VihasMakwana assigned |
…34985) **Description:** This PR introduces a new option that will create a directory for the user if it doesn't already exist. **Link to tracking Issue:** #34939 **Testing:** Added --------- Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
Addressed via #34985. Closing. |
…pen-telemetry#34985) **Description:** This PR introduces a new option that will create a directory for the user if it doesn't already exist. **Link to tracking Issue:** open-telemetry#34939 **Testing:** Added --------- Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
Component(s)
extension/storage/filestorage
Is your feature request related to a problem? Please describe.
When using the
filelog
receiver with persistence enabled, I need to ensure that the directory exists before starting the collector; otherwise, it will throw an error.It would be a great help if collector could automate this part for me.
Describe the solution you'd like
It would be convenient if the
file_storage
option had a setting that, when enabled, would automatically create the directory for you.We can name the option
auto_create_directory
orcreate_directory
and set it tofalse
by default (existing behaviour), but if the user wants the collector to handle the directory creation, they can just turn this option on.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: