[exporter/tanzuobservability] exponential histogram adjustment. #10135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of the extra negative bucket which always has a count of 0.
|
cc @oppegard @thepeterstone |
|
@oppegard and @thepeterstone are the Tech Leads, but they are both out of the office for now. @deosu is going to review the code first. |
dashpole
approved these changes
May 20, 2022
oppegard
approved these changes
May 26, 2022
codeboten
approved these changes
May 26, 2022
codeboten
added
the
ready to merge
codeboten
changed the title
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…-telemetry#10135) [exporter/tanzuoservability] exponential histogram adjustment. Get rid of the extra negative bucket which always has a count of 0. Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Get rid of the smallest negative bucket which always has a count of 0. This smallest negative bucket with count of 0 was here to give the bucket above it a lower bound. But during testing we found that most histograms have positive values anyway. It was confusing to see a "<= -1" bucket show up all the time, so we decided to get rid of this bucket.
Link to tracking Issue: Issue is private and not linkable.
Testing: Unit tests and manual testing with the collector.