Update OTLP-Jaeger translation of events according to the spec #10273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-jaeger-translation
branch
from
4b72bc4
to
b08ba8d
Compare
Name field of a span event was mapped to a Jaeger log with `message` key which has a different meaning in OpenTracing specification: https://github.com/opentracing/specification/blob/master/semantic_conventions.md#log-fields-table. This change update OTLP-Jaeger translation of Span events according to the OTel Spec saying that `Name` field should be mapped to `event` Jaeger attribute: https://github.com/open-telemetry/opentelemetry-specification/blob/34b907207f3dfe1635a35c4cdac6b6ab3a495e18/specification/trace/sdk_exporters/jaeger.md#events
dmitryax
force-pushed
the
fix-jaeger-translation
branch
from
b08ba8d
to
70eb5f2
Compare
pmm-sumo
approved these changes
May 24, 2022
dmitryax
added
the
ready to merge
bogdandrutu
reviewed
May 24, 2022
Comment on lines
+28
to
+30
| // eventNameAttr is a Jaeger log field key used to represent OTel Span Event Name as defined by the OpenTelemetry Specification: | ||
| // https://github.com/open-telemetry/opentelemetry-specification/blob/34b907207f3dfe1635a35c4cdac6b6ab3a495e18/specification/trace/sdk_exporters/jaeger.md#events | ||
| const eventNameAttr = "event" |
There was a problem hiding this comment.
Should we make this a featuregate protected change?
There was a problem hiding this comment.
We could. I just don't think this change is that impactful. WDYT? Should we?
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…telemetry#10273) Name field of a span event was mapped to a Jaeger log with `message` key which has a different meaning in OpenTracing specification: https://github.com/opentracing/specification/blob/master/semantic_conventions.md#log-fields-table. This change update OTLP-Jaeger translation of Span events according to the OTel Spec saying that `Name` field should be mapped to `event` Jaeger attribute: https://github.com/open-telemetry/opentelemetry-specification/blob/34b907207f3dfe1635a35c4cdac6b6ab3a495e18/specification/trace/sdk_exporters/jaeger.md#events
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
1 task
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Adjust code to opentelemetry-collector changes Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events, and OTLP logs. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances. open-telemetry/opentelemetry-proto#373 removed the deprecated LogRecord.Name field. There is no replacement, hence we no longer record `event.action`.
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
axw
added a commit
to elastic/apm-server
that referenced
this pull request
Aug 2, 2022
* Update opentelemetry-collector modules to v0.56.0 * Adjust code to opentelemetry-collector changes Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances. * systemtest: update otel libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name field of a span event was mapped to a Jaeger log field with
messagekey which has a different meaning in OpenTracing specification: https://github.com/opentracing/specification/blob/master/semantic_conventions.md#log-fields-table.This change updates OTLP-Jaeger translation of Span events according to the OTel Spec saying that
Namefield must be mapped toeventJaeger log field: https://github.com/open-telemetry/opentelemetry-specification/blob/34b907207f3dfe1635a35c4cdac6b6ab3a495e18/specification/trace/sdk_exporters/jaeger.md#eventsResolves #10268