[k8sclusterreceiver]: Remove the receiver.k8sclusterreceiver.reportCpuMetricsAsDouble feature gate #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoravong
force-pushed
the
OTL-remove-feature-gate
branch
from
1fe6ddf
to
cac3ee7
Compare
jvoravong
changed the title
TylerHelmuth
reviewed
Jun 8, 2022
|
No testes need to be updated for containers.go and collector.go. |
TylerHelmuth
approved these changes
Jun 9, 2022
|
For some reason I closed this PR without getting the commits merged, that was a mistake on my part. Reopening this PR, will make updates if needed. |
jvoravong
force-pushed
the
OTL-remove-feature-gate
branch
from
cce8cd9
to
2c47bb3
Compare
dmitryax
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moving the receiver.k8sclusterreceiver.reportCpuMetricsAsDouble feature gate from its Beta stage to its GA stage for release v0.54.0. The feature gate will now no longer exist.
Link to tracking Issue:
This is a planned cleanup PR, so I did not create a new issue.
Here is the original related issue: Fix k8s node and container cpu metrics not being reported properly #8245
Testing:
Verified the feature gate was safely removed and cpu metrics look proper.
Documentation:
Updated the README.md notes to remove the feature gate information.
Updated the CHANGLOG.md entries to point at v0.53.0 of the feature gate information.
Alpha Stage PR: #8245
Beta Stage PR: #9367