-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/dynatraceexporter] Update serialization #11828
Merged
codeboten
merged 22 commits into
open-telemetry:main
from
dynatrace-oss-contrib:dt-updates
Jul 7, 2022
Merged
[exporter/dynatraceexporter] Update serialization #11828
codeboten
merged 22 commits into
open-telemetry:main
from
dynatrace-oss-contrib:dt-updates
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple very minor nits. This has already been reviewed internally at Dynatrace
I updated the PR to not include a Changelog directly in the .md file and added a YAML file instead. |
codeboten
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR updates how certain OpenTelemetry internal representations are serialized to the Dynatrace wire format. Also, some deprecated fields were updated. Serialization methods were renamed to be more speaking. Overall, this PR adds a few things but is mostly cleanup and maintenance.
Testing: Added tests to make sure data is serialized correctly.