Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/dynatraceexporter] Update serialization #11828

Merged
merged 22 commits into from
Jul 7, 2022

Conversation

pirgeo
Copy link
Member

@pirgeo pirgeo commented Jun 30, 2022

Description: This PR updates how certain OpenTelemetry internal representations are serialized to the Dynatrace wire format. Also, some deprecated fields were updated. Serialization methods were renamed to be more speaking. Overall, this PR adds a few things but is mostly cleanup and maintenance.

Testing: Added tests to make sure data is serialized correctly.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple very minor nits. This has already been reviewed internally at Dynatrace

exporter/dynatraceexporter/internal/serialization/gauge.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
exporter/dynatraceexporter/internal/serialization/sum.go Outdated Show resolved Hide resolved
exporter/dynatraceexporter/internal/serialization/sum.go Outdated Show resolved Hide resolved
@arminru arminru added the comp:dynatrace Dynatrace components label Jul 7, 2022
@pirgeo
Copy link
Member Author

pirgeo commented Jul 7, 2022

I updated the PR to not include a Changelog directly in the .md file and added a YAML file instead.

@codeboten codeboten merged commit 0959405 into open-telemetry:main Jul 7, 2022
@pirgeo pirgeo deleted the dt-updates branch July 8, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:dynatrace Dynatrace components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants