3/3 Extend Windows Performance Counters Receiver to support counters with instances #1229
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Please rebase |
james-bebbington
force-pushed
the
windowsperfcounters-receiver-3
branch
from
cb89f19
to
8e9622a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
==========================================
+ Coverage 88.67% 88.68% +0.01%
==========================================
Files 343 343
Lines 16753 16756 +3
==========================================
+ Hits 14855 14860 +5
+ Misses 1432 1431 -1
+ Partials 466 465 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
windowsperfcounters-receiver-3
branch
2 times, most recently
from
f88ff1f
to
abe7a90
Compare
|
All depencies have been merged and this is now ready for review |
james-bebbington
force-pushed
the
windowsperfcounters-receiver-3
branch
2 times, most recently
from
92d4a49
to
d75c068
Compare
| Object string `mapstructure:"object"` | ||
| Counters []string `mapstructure:"counters"` | ||
| Object string `mapstructure:"object"` | ||
| Instances []string `mapstructure:"instances"` |
There was a problem hiding this comment.
Do you think we should consider being able to collect certain counters from only certain instances in the config? Or would one do this by using different receiver configs? For example, a case where one is interested in collecting counterA and counterB from instanceA only, and counterA and counterC from instanceB only.
There was a problem hiding this comment.
If I understand you correctly, this is supported, as per the example here and test here. You can achieve what you want as there's no limitation that you can only specify an Object once. Let me know if I missed something there.
Aside: there's currently no validation to stop you setting up completely duplicate counters, although I did leave a comment here mentioning we should consider adding such validation in the future.
There was a problem hiding this comment.
Ah yes, that's what I was referring to, thanks for pointing me to it!
james-bebbington
force-pushed
the
windowsperfcounters-receiver-3
branch
from
d75c068
to
78664a3
Compare
Add custom `markdown-link-check` to ignore 429 responses. Diff with https://github.com/tcort/markdown-link-check/blob/v3.8.1/markdown-link-check: ``` < const markdownLinkCheck = require('markdown-link-check'); --- > const markdownLinkCheck = require('./'); 134,138d133 < // workaround to ignore 429 responses (too many requests) < if (result.statusCode === 429) { < result.status = 'ignored' < } < ``` **Link to tracking Issue:** **Testing:** Tested locally with `circleci` command line tool. **Documentation:** Updated .circleci/check-links/README.md.
* Move trace API to otel * Move tracetest to oteltest * Update package documentation * Remove old api/trace package * Lint * Add changes to CHANGELOG * Add tests for rest of trace API * Apply suggestions from code review Co-authored-by: Anthony Mirabella <[email protected]> * Documentation fixes Includes resolutions for review issues. * Correct CHANGELOG post release Co-authored-by: Anthony Mirabella <[email protected]>
Link to tracking Issue: #1088
Description: Extend the Windows Performance Counters Receiver to support counters that includes "instances".
Testing: Coverage is not reported for code behind non-Linux build flags, but it is over 95% on Windows for this component: