[receiver/hostmetricsreceiver] Add threads count metric #12802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this metric important enough to be enabled by default? It'll be a breaking change and will change amount of data that users collect and send to backends by default after upgrade. I think this should be an optional metric |
|
Made it optional, thanks for the feedback! |
atoulme
force-pushed
the
add_threads_count
branch
4 times, most recently
from
66ea504
to
b6bee3a
Compare
|
This receiver has all the metrics defined in semantic conventions. This new metric should also be submitted there first even if it's optional, just to avoid further changes if this PR is merged first |
|
Opened this PR to update the specification open-telemetry/opentelemetry-specification#2705 |
atoulme
force-pushed
the
add_threads_count
branch
3 times, most recently
from
ca55042
to
1552f3b
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
force-pushed
the
add_threads_count
branch
from
1552f3b
to
2f0b530
Compare
atoulme
force-pushed
the
add_threads_count
branch
from
2f0b530
to
55d3a17
Compare
dmitryax
reviewed
Aug 18, 2022
receiver/hostmetricsreceiver/internal/scraper/processscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go
Show resolved
Hide resolved
dmitryax
approved these changes
Aug 18, 2022
receiver/hostmetricsreceiver/internal/scraper/processscraper/metadata.yaml
Show resolved
Hide resolved
atoulme
force-pushed
the
add_threads_count
branch
from
fde9a85
to
ea7ddc5
Compare
atoulme
force-pushed
the
add_threads_count
branch
from
ea7ddc5
to
1bde002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add threads count metric to hostmetricsreceiver.
Link to tracking Issue:
#12482
Testing:
Supported with mock as part of unit tests, checking error is reported.
Documentation:
Addition to documentation of the new metric.