-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/dockerstats] Combine and simplify multiple blockio metrics by making "operation" an attribute #13445
[receiver/dockerstats] Combine and simplify multiple blockio metrics by making "operation" an attribute #13445
Conversation
@rmfitzpatrick @MovieStoreGuy FYI + please review if you have time 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense to me.
Hi @rmfitzpatrick @djaglowski just bumping this PR |
These changes seem good to me, and I imagine similar updates can be made to the |
@jpkrohling @djaglowski I have codeowner approval and one other approval. Can I get this reviewed/merged please 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving by proxy
Description:
Instead of having several blockio metrics with the operation appended on the name as
.read, .write, .sync, .async, .total, .discard
we pull the operation out into an attribute. This simplifies the code a lot:This is a breaking change for anyone using the featuregated v2 implementation, which is not enabled by default yet. To my knowledge, no one is using the new v2 implementation yet.
Link to tracking Issue: #9794
Testing:
The tests logic remain the same, but the expected metrics are updates to align with the changes.
Documentation:
Documentation automatically updated by
go generate
.