Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/splunkhec] Skip datapoint.Sum NaN values #14876

Merged
merged 8 commits into from
Oct 18, 2022
Merged

[exporter/splunkhec] Skip datapoint.Sum NaN values #14876

merged 8 commits into from
Oct 18, 2022

Conversation

hvaghani221
Copy link
Member

@hvaghani221 hvaghani221 commented Oct 11, 2022

Fixes #14877

SummaryDataPoint.Sum and HistogramDataPoint.Sum method may return NaN value. It may cause an error during JSON marshal

@hvaghani221 hvaghani221 requested a review from a team October 11, 2022 13:14
@hvaghani221 hvaghani221 marked this pull request as draft October 11, 2022 14:08
@hvaghani221 hvaghani221 marked this pull request as ready for review October 12, 2022 06:51
@hvaghani221 hvaghani221 changed the title [exporter/splunkhec] sanitize datapoint.Sum function output [exporter/splunkhec] Skip datapoint.Sum NaN values Oct 18, 2022
@hvaghani221 hvaghani221 changed the title [exporter/splunkhec] Skip datapoint.Sum NaN values [exporter/splunkhec] Skip datapoint.Sum NaN values Oct 18, 2022
@dmitryax dmitryax merged commit 0e933a7 into open-telemetry:main Oct 18, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/splunkhec] dropped metric event because of unsupported value: NaN
6 participants