-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/splunkhec] Skip datapoint.Sum NaN values #14876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Oct 12, 2022
dmitryax
reviewed
Oct 17, 2022
dmitryax
approved these changes
Oct 18, 2022
hvaghani221
changed the title
[exporter/splunkhec] sanitize datapoint.Sum function output
[exporter/splunkhec] Skip Oct 18, 2022
datapoint.Sum
NaN values
hvaghani221
changed the title
[exporter/splunkhec] Skip
[exporter/splunkhec] Skip datapoint.Sum NaN values
Oct 18, 2022
datapoint.Sum
NaN values
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
) Co-authored-by: Dmitrii Anoshin <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14877
SummaryDataPoint.Sum
andHistogramDataPoint.Sum
method may returnNaN
value. It may cause an error during JSON marshal