[receiver/elasticsearch]: add fielddata memory size metrics on index level #14922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboguszewski-sumo
force-pushed
the
elasticsearch-fielddata
branch
from
19ce759
to
72441d5
Compare
djaglowski
approved these changes
Oct 20, 2022
|
Please resolve conflict |
aboguszewski-sumo
force-pushed
the
elasticsearch-fielddata
branch
from
72441d5
to
c8e9efb
Compare
|
Rebased. |
aboguszewski-sumo
force-pushed
the
elasticsearch-fielddata
branch
from
c8e9efb
to
6d76f00
Compare
|
@djaglowski You already approved it, but since in the meantime the approach regarding adding new metrics has changed, I marked this new metric as disabled by default. The PR is rebased now. |
|
Thanks @aboguszewski-sumo. Unfortunately it looks like we need another rebase |
aboguszewski-sumo
force-pushed
the
elasticsearch-fielddata
branch
from
6d76f00
to
05b3a39
Compare
|
Rebased. |
|
@djaglowski can we merge it, or is something more needed? |
|
Adding "ready-to-merge" to not forget that it is only the test that we are waiting for |
bogdandrutu
added
the
ready to merge
mdelapenya
added a commit
to mdelapenya/opentelemetry-collector-contrib
that referenced
this pull request
Nov 15, 2022
* main: [chore] dependabot updates Tue Nov 15 00:17:56 UTC 2022 (open-telemetry#16300) [receiver/rabbitmq] Fix flaky integration test (open-telemetry#16240) [Docker Stats Receiver] Add @jamesmoessis as code owner (open-telemetry#16253) [receiver/mongodbatlas] Alerts poll mode check hostname and port (open-telemetry#16286) [chore] update jaeger dep (open-telemetry#16287) [pkg/stanza] Fix issue where specifying a non-existent storage extension caused panic during shutdown. (open-telemetry#16213) [pkg/ottl] Rename ottllogs to ottllog (open-telemetry#16242) Register featuregate, otherwise does not work (open-telemetry#16269) [receiver/elasticsearch]: add fielddata memory size metrics on index level (open-telemetry#14922) [chore] remove what looks to be debugging code from instanaexporter (open-telemetry#16258)
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…level (open-telemetry#14922) feat: add fielddata memory size metrics on index level
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…level (open-telemetry#14922) feat: add fielddata memory size metrics on index level
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New metrics related to memory size of fielddata cache are now emitted.
The same metrics were already emitted on node-level, so I tried to keep their description in
metadata.yamlas close as possible.Link to tracking Issue: #14635
Testing:
Unit and integration tests.
Documentation:
mdatagen