[chore] Remove sqlite compilation warnings

[atoulme]

This PR adds a CGO flag to the make test command for the extension/storage extension that explicitly disables warnings from the sqlite go library. See mattn/go-sqlite3#803 for context. Note I also added -Wno-unknown-warning-option as some versions of gcc do not recognize the -Wno-return-local-addr flag.

This PR will remove those warnings from the build:

# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~

[runforesight]

Foresight Summary

    
Major Impacts

build-and-test-windows duration(6 seconds) has decreased 45 minutes 25 seconds compared to main branch avg(45 minutes 31 seconds).

View More Details

✅  check-links workflow has finished in 54 seconds (1 minute 42 seconds less than main branch avg.) and finished at 1st Mar, 2023.

---

Job	Failed Steps	Tests
changed files	-     🔗	N/A	See Details
check-links	-     🔗	N/A	See Details

---

✅  telemetrygen workflow has finished in 1 minute 6 seconds (2 minutes 8 seconds less than main branch avg.) and finished at 1st Mar, 2023.

---

Job	Failed Steps	Tests
build-dev	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details
publish-latest	-     🔗	N/A	See Details

---

✅  prometheus-compliance-tests workflow has finished in 3 minutes 44 seconds (5 minutes 31 seconds less than main branch avg.) and finished at 1st Mar, 2023.

---

Job	Failed Steps	Tests
prometheus-compliance-tests	-     🔗	✅ 21  ❌ 0  ⏭ 0    🔗	See Details

---

✅  build-and-test workflow has finished in 35 minutes 48 seconds (36 minutes 52 seconds less than main branch avg.) and finished at 1st Mar, 2023.

---

Job	Failed Steps	Tests
unittest-matrix (1.20, internal)	-     🔗	✅ 561  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, internal)	-     🔗	✅ 561  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, processor)	-     🔗	✅ 1525  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, processor)	-     🔗	✅ 1525  ❌ 0  ⏭ 0    🔗	See Details
correctness-metrics	-     🔗	✅ 2  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, extension)	-     🔗	✅ 537  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, extension)	-     🔗	✅ 537  ❌ 0  ⏭ 0    🔗	See Details
correctness-traces	-     🔗	✅ 17  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, receiver-0)	-     🔗	✅ 2580  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, receiver-0)	-     🔗	✅ 2580  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, exporter)	-     🔗	✅ 2456  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, exporter)	-     🔗	✅ 2456  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, receiver-1)	-     🔗	✅ 1937  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, receiver-1)	-     🔗	✅ 1937  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.20, other)	-     🔗	✅ 4788  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, other)	-     🔗	✅ 4788  ❌ 0  ⏭ 0    🔗	See Details
integration-tests	-     🔗	✅ 55  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details
build-examples	-     🔗	N/A	See Details
check-codeowners	-     🔗	N/A	See Details
check-collector-module-version	-     🔗	N/A	See Details
checks	-     🔗	N/A	See Details
lint-matrix (receiver-0)	-     🔗	N/A	See Details
lint-matrix (receiver-1)	-     🔗	N/A	See Details
lint-matrix (processor)	-     🔗	N/A	See Details
lint-matrix (exporter)	-     🔗	N/A	See Details
lint-matrix (extension)	-     🔗	N/A	See Details
lint-matrix (internal)	-     🔗	N/A	See Details
lint-matrix (other)	-     🔗	N/A	See Details
lint	-     🔗	N/A	See Details
unittest (1.20)	-     🔗	N/A	See Details
unittest (1.19)	-     🔗	N/A	See Details
cross-compile (darwin, amd64)	-     🔗	N/A	See Details
cross-compile (darwin, arm64)	-     🔗	N/A	See Details
cross-compile (linux, 386)	-     🔗	N/A	See Details
cross-compile (linux, amd64)	-     🔗	N/A	See Details
cross-compile (linux, arm)	-     🔗	N/A	See Details
cross-compile (linux, arm64)	-     🔗	N/A	See Details
cross-compile (linux, ppc64le)	-     🔗	N/A	See Details
cross-compile (windows, 386)	-     🔗	N/A	See Details
cross-compile (windows, amd64)	-     🔗	N/A	See Details
build-package (deb)	-     🔗	N/A	See Details
build-package (rpm)	-     🔗	N/A	See Details
windows-msi	-     🔗	N/A	See Details
publish-check	-     🔗	N/A	See Details
publish-dev	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details

---

✅  load-tests workflow has finished in 7 minutes 5 seconds (10 minutes 44 seconds less than main branch avg.) and finished at 1st Mar, 2023.

---

Job	Failed Steps	Tests
loadtest (TestIdleMode)	-     🔗	✅ 1  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceAttributesProcessor)	-     🔗	✅ 3  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile)	-     🔗	✅ 6  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs)	-     🔗	✅ 8  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs)	-     🔗	✅ 10  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS)	-     🔗	✅ 12  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details
loadtest (TestBallastMemory|TestLog10kDPS)	-     🔗	✅ 18  ❌ 0  ⏭ 0    🔗	See Details

---

✅  e2e-tests workflow has finished in 14 minutes 16 seconds (2 minutes 27 seconds less than main branch avg.) and finished at 1st Mar, 2023.

---

Job	Failed Steps	Tests
kubernetes-test (v1.26.0)	-     🔗	N/A	See Details
kubernetes-test (v1.24.7)	-     🔗	N/A	See Details
kubernetes-test (v1.25.3)	-     🔗	N/A	See Details
kubernetes-test (v1.23.13)	-     🔗	N/A	See Details

---

⭕  changelog workflow has finished in 4 seconds (2 minutes 40 seconds less than main branch avg.) and finished at 6th Mar, 2023.

---

Job	Failed Steps	Tests
changelog	-     🔗	N/A	See Details

---

⭕  build-and-test-windows workflow has finished in 6 seconds (45 minutes 25 seconds less than main branch avg.) and finished at 6th Mar, 2023.

---

Job	Failed Steps	Tests
windows-unittest-matrix	-     🔗	N/A	See Details
windows-unittest	-     🔗	N/A	See Details

---

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

[codeboten]

Looking at the last comment in the issue you linked:

@shalota1 gophish is using v2.0.3 of this library, which is quite old. You will need to ask the maintainer to upgrade to the latest version (v1.14.14) and try that.

Does updating the version resolve the warnings? Is it an option?

[atoulme]

You are correct! I opened a chore PR to update the version here: #19421

[atoulme]

ok no need for those changes anymore, closing.