[mongodbreceiver] Fix get mongodb version #27442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Oct 5, 2023
crobert-1
approved these changes
Oct 5, 2023
djaglowski
approved these changes
Oct 6, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** <Describe what has changed.> - Improve the unit-test to catch similar errors in the future. - Fix mongodb version collection. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27441 **Testing:** <Describe what testing was performed and which tests were added.> Added the expectation assert for the Mock. This is the log output from running the tests in the first catching the bug ``` --- FAIL: TestScraperScrape (0.00s) --- FAIL: TestScraperScrape/Failed_to_fetch_database_names (0.00s) pathTo/opentelemetry-collector-contrib/receiver/mongodbreceiver/scraper_test.go:316: FAIL: GetVersion(string) at: [pathTo/opentelemetry-collector-contrib/receiver/mongodbreceiver/scraper_test.go:146 pathTo/opentelemetry-collector-contrib/receiver/mongodbreceiver/scraper_test.go:292] pathTo/opentelemetry-collector-contrib/receiver/mongodbreceiver/scraper_test.go:316: PASS: ListDatabaseNames(string,string,string) pathTo/opentelemetry-collector-contrib/receiver/mongodbreceiver/scraper_test.go:316: FAIL: 1 out of 2 expectation(s) were met. The code you are testing needs to make 1 more call(s). at: [pathTo/opentelemetry-collector-contrib/receiver/mongodbreceiver/scraper_test.go:316] ``` **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
#27441
Testing:
Added the expectation assert for the Mock.
This is the log output from running the tests in the first catching the bug
Documentation: