Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mysql] expose tls config #29269

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

s-v-a-n
Copy link
Contributor

@s-v-a-n s-v-a-n commented Nov 14, 2023

Description:
Using the mysqlreceiver, we were getting the following error as our MySQL server on AWS RDS requires secure transport for all connections by setting require_secure_transport=ON per https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/mysql-ssl-connections.html#mysql-ssl-connections.require-ssl

Example log message
2023-10-31T10:53:30.239Z error scraperhelper/scrapercontroller.go:200 Error scraping metrics {"kind": "receiver", "name": "mysql", "data_type": "metrics", "error": "Error 3159 (HY000): Connections using insecure transport are prohibited while --require_secure_transport=ON.; ", "scraper": "mysql"}

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

.chloggen/main.yaml Outdated Show resolved Hide resolved
.chloggen/main.yaml Outdated Show resolved Hide resolved
receiver/mysqlreceiver/client.go Outdated Show resolved Hide resolved
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just would like one more test for the custom unmarshaling logic.

receiver/mysqlreceiver/config_test.go Show resolved Hide resolved
@s-v-a-n
Copy link
Contributor Author

s-v-a-n commented Nov 17, 2023

@djaglowski : please let me know if this is good to go. Thank you

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit 7337273 into open-telemetry:main Nov 17, 2023
83 checks passed
@djaglowski
Copy link
Member

Thanks for this improvement @s-v-a-n!

@github-actions github-actions bot added this to the next release milestone Nov 17, 2023
aishyandapalli pushed a commit to aishyandapalli/opentelemetry-collector-contrib that referenced this pull request Nov 17, 2023
**Description:** 
Using the mysqlreceiver, we were getting the following error as our
MySQL server on AWS RDS requires secure transport for all connections by
setting `require_secure_transport=ON` per
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/mysql-ssl-connections.html#mysql-ssl-connections.require-ssl

**Example log message**
`2023-10-31T10:53:30.239Z error scraperhelper/scrapercontroller.go:200
Error scraping metrics {"kind": "receiver", "name": "mysql",
"data_type": "metrics", "error": "Error 3159 (HY000): Connections using
insecure transport are prohibited while --require_secure_transport=ON.;
", "scraper": "mysql"}`
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
**Description:** 
Using the mysqlreceiver, we were getting the following error as our
MySQL server on AWS RDS requires secure transport for all connections by
setting `require_secure_transport=ON` per
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/mysql-ssl-connections.html#mysql-ssl-connections.require-ssl

**Example log message**
`2023-10-31T10:53:30.239Z error scraperhelper/scrapercontroller.go:200
Error scraping metrics {"kind": "receiver", "name": "mysql",
"data_type": "metrics", "error": "Error 3159 (HY000): Connections using
insecure transport are prohibited while --require_secure_transport=ON.;
", "scraper": "mysql"}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants