Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] move carbon exporter to generated lifecycle tests #30516

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

Frapschen
Copy link
Contributor

Relates to #27849

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 27, 2024
@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Please rebase

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Please rebase

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Pinging @aboguszewski-sumo for codeowner review

@atoulme
Copy link
Contributor

atoulme commented Feb 9, 2024

We have the approvals, just need a rebase and updating collector versions.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@dmitryax
Copy link
Member

@Frapschen can you please rebase?

@dmitryax dmitryax merged commit 94a5adb into open-telemetry:main Mar 1, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 1, 2024
@Frapschen Frapschen deleted the carbon_expoter_lifecycle branch March 5, 2024 11:16
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants