-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] move prometheus exporter to generated lifecycle tests #30540
Merged
dmitryax
merged 4 commits into
open-telemetry:main
from
Frapschen:prometheus_exporter_lifecycle
Mar 1, 2024
Merged
[chore] move prometheus exporter to generated lifecycle tests #30540
dmitryax
merged 4 commits into
open-telemetry:main
from
Frapschen:prometheus_exporter_lifecycle
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Jan 15, 2024
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
codeboten
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging code owner @Aneurysm9 please review
atoulme
force-pushed
the
prometheus_exporter_lifecycle
branch
from
January 31, 2024 19:51
8984cdb
to
fee7d8d
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Feb 28, 2024
@Frapschen please rebase and take a look at the failing CI |
atoulme
force-pushed
the
prometheus_exporter_lifecycle
branch
from
March 1, 2024 07:04
1dd9dfb
to
47e197a
Compare
dmitryax
approved these changes
Mar 1, 2024
Ci is still failing |
atoulme
force-pushed
the
prometheus_exporter_lifecycle
branch
from
March 1, 2024 16:28
47e197a
to
7d87819
Compare
dmitryax
approved these changes
Mar 1, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…elemetry#30540) Relates to open-telemetry#27849 --------- Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #27849