[processor/filter] mv from opencensus to otel #30736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
@codeboten is this a breaking change for users who are using the telemetry.useOtelWithSDKConfigurationForInternalTelemetry feature gate to export metrics using the OTel GO SDK?
|
Moved back to draft until i fix a missing attribute issue i found while testing manually |
|
@TylerHelmuth confirmedthis is not a breaking change. The current metric emitted look like: Although it's currently not working because of this bug open-telemetry/opentelemetry-collector#9361 |
added 4 commits
January 24, 2024 14:14
This moves the telemetry generated by the processor from using opencensus to using otel. Note that the test checks the name of the metric in the format that it is generated using the meter provider, hence the change from `processor_filter_datapoints_filtered` to `processor/filter/datapoints.filtered`. When using the prometheus exporter, the output name will be the same as before. Fixes open-telemetry#30734 Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/rm-census-filter
branch
from
a2e1455
to
7a30384
Compare
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
This moves the telemetry generated by the processor from using opencensus to using otel. Note that the test checks the name of the metric in the format that it is generated using the meter provider, hence the change from `processor_filter_datapoints_filtered` to `processor/filter/datapoints.filtered`. When using the prometheus exporter, the output name will be the same as before. Fixes open-telemetry#30734 --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the telemetry generated by the processor from using opencensus to using otel. Note that the test checks the name of the metric in the format that it is generated using the meter provider, hence the change from
processor_filter_datapoints_filteredtoprocessor/filter/datapoints.filtered. When using the prometheus exporter, the output name will be the same as before.Fixes #30734