Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Add copy_metric function #30846

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Adds a new function to the metric functions that allows copying the current TransformContext's method.

Link to tracking Issue:

Closes #16221

Testing:

unit tests

Documentation:

Updated README

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. I like the way this leverages optional parameters.

processor/transformprocessor/README.md Outdated Show resolved Hide resolved
processor/transformprocessor/README.md Show resolved Hide resolved
processor/transformprocessor/README.md Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 688aca5 into open-telemetry:main Jan 31, 2024
95 checks passed
@TylerHelmuth TylerHelmuth deleted the transformprocessor-copy-metric branch January 31, 2024 17:07
@github-actions github-actions bot added this to the next release milestone Jan 31, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
**Description:** 
Adds a new function to the metric functions that allows copying the
current TransformContext's method.

**Link to tracking Issue:** <Issue number if applicable>

Closes
open-telemetry#16221

**Testing:** <Describe what testing was performed and which tests were
added.>

unit tests

**Documentation:**

Updated README

---------

Co-authored-by: Evan Bradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/transform Transform processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/transform] Create new metrics from existing ones
3 participants