-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/deltatocumulative]: observe accumulation metrics #31363
[processor/deltatocumulative]: observe accumulation metrics #31363
Conversation
When I was trying out this processor I was wondering how to debug it and ended up pretty much just reading all the code and adding Printfs. The set of metrics from this PR would have helped a lot! One nitpick on naming: |
64a6c7d
to
26e5ec0
Compare
I don't understand the need for the Otherwise looks fine to me. |
processor/deltatocumulativeprocessor/internal/telemetry/metrics.go
Outdated
Show resolved
Hide resolved
These need to sit at different stages in the pipeline
@RichieSams @djaglowski I think this is ready for final review, please take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main code looks nice, but I'm missing tests for the new behavior that was introduced.
Description:
Uses the otel meter to observe some key metrics about the accumulation:
streams_count
datapoints_processed
datapoints_dropped
reason
attributeseconds_lost
Link to tracking Issue:
#30705
Testing: None
Documentation: Readme updated