Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/sumologic] sync internal package with Sumo Logic repository #31480

Merged

Conversation

sumo-drosiek
Copy link
Member

Description:

Those files can be added independently of their usage which should make other PRs smaller

Link to tracking Issue: #31479

Testing:

Unit tests

Documentation: N/A

Dominik Rosiek added 4 commits March 6, 2024 09:58
@sumo-drosiek
Copy link
Member Author

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a "feature" as the commit message suggests? Looks more like a refactoring/chore.

Does adding these files change anything in the bahavior of the exporter?

@sumo-drosiek
Copy link
Member Author

Does adding these files change anything in the bahavior of the exporter?

It adds metrics to the collector, but not now. This PR is purely to reduce size of final PR. I would add skip changelog label. I don't have strong feeling towards feat nor chore

@sumo-drosiek sumo-drosiek changed the title feat(sumologicexporter): sync internal package with Sumo Logic repository chore(sumologicexporter): sync internal package with Sumo Logic repository Mar 6, 2024
@andrzej-stencel
Copy link
Member

If it doesn't change the behavior of the exporter, then it's definitely not a feat. Let's make it a chore.

@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 6, 2024
@andrzej-stencel andrzej-stencel changed the title chore(sumologicexporter): sync internal package with Sumo Logic repository [chore] [exporter/sumologic] sync internal package with Sumo Logic repository Mar 6, 2024
Signed-off-by: Dominik Rosiek <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 4, 2024
@sumo-drosiek
Copy link
Member Author

cc: @open-telemetry/collector-contrib-maintainer

@github-actions github-actions bot removed the Stale label Apr 5, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts

@andrzej-stencel andrzej-stencel merged commit decc66f into open-telemetry:main Apr 9, 2024
169 of 170 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 9, 2024
@sumo-drosiek sumo-drosiek deleted the drosiek-exporter-internal branch April 10, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/sumologic Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants