[receiver/chrony] generated lifecycle tests #31524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
chronyreceiver_lifecycle
branch
from
10abaf0
to
df79f25
Compare
…alization of the chrony client to the start function
atoulme
force-pushed
the
chronyreceiver_lifecycle
branch
from
df79f25
to
e40fa3a
Compare
dmitryax
approved these changes
Mar 1, 2024
dmitryax
reviewed
Mar 1, 2024
|
|
||
| tests: | ||
| config: | ||
| skip_lifecycle: true |
There was a problem hiding this comment.
If you try to start the receiver, it fails looking for the chrony socket file.
There was a problem hiding this comment.
So why do we need to do the functional changes if the test fails anyway? That can be done separately right?
There was a problem hiding this comment.
The generated tests test two scenarios:
- lifecycle, meaning we start and stop the receiver with a configuration, and make sure it is able to run. This is skipped.
- shutdown: we create the receiver and call .Shutdown on it. We check the receiver doesn't panic on this unexpected call.
There was a problem hiding this comment.
I know. so the shutdown part is failing without functional changes?
There was a problem hiding this comment.
Indeed, the current behavior of the chrony receiver is to create a chrony client before creating the receiver. This client immediately looks up a file on disk and fails. Moving the chrony client creation to start helps.
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Add generated tests for chrony receiver; move initialization of the chrony client to the start function **Link to tracking Issue:** Relates to open-telemetry#27849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add generated tests for chrony receiver; move initialization of the chrony client to the start function
Link to tracking Issue:
Relates to #27849