Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] Move processor.resourcedetection.hostCPUSteppingAsString to beta #33076

Merged
merged 1 commit into from
May 15, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented May 15, 2024

Description:

Follow up to #31165. The feature gate has been in alpha since v0.95.0.

Link to tracking Issue: Relates to #31136 and open-telemetry/semantic-conventions#664

cc @ChrsMark

@mx-psi mx-psi requested a review from a team May 15, 2024 17:24
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label May 15, 2024
@andrzej-stencel
Copy link
Member

I'm a bit worried that this feature gate and its schedule is not described in the README. Shouldn't this be fixed (in a separate pull request)?

@andrzej-stencel andrzej-stencel merged commit 1b48abf into open-telemetry:main May 15, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone May 15, 2024
@mx-psi
Copy link
Member Author

mx-psi commented May 15, 2024

I'm a bit worried that this feature gate and its schedule is not described in the README. Shouldn't this be fixed (in a separate pull request)?

I think it would be nice to have this. If this is required for all feature gates, we should document this requirement somewhere (CONTRIBUTING.md?). Better yet, have it autogenerated through open-telemetry/opentelemetry-collector/issues/9860

mx-psi pushed a commit that referenced this pull request Sep 16, 2024
…USteppingAsString feature gate to stable (#35202)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Follows
#33076
and
#31165.

**Link to tracking Issue:** <Issue number if applicable>
#31136

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

/cc @mx-psi

Signed-off-by: ChrsMark <[email protected]>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…USteppingAsString feature gate to stable (open-telemetry#35202)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Follows
open-telemetry#33076
and
open-telemetry#31165.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#31136

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

/cc @mx-psi

Signed-off-by: ChrsMark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/resourcedetection Resource detection processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants