Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearchexporter] Fix bulk indexer to capture indexing errors for collector events metrics #33585

Conversation

lalith47
Copy link

Description:
Return Elasticsearch bulk indexer errors if any so OTEL Collector would count them properly in its internal metrics.
For address this, added error channel in bulk indexer so that it can send error to the channel.

Link to tracking Issue: #32302
Testing:
In Progress

This approach has some issues. When failed events are received otelcol_exporter_sent_log_records otelcol_exporter_send_failed_log_records both are incrementing incorrectly.

From debugging, found that documents are periodically flushed for a given flushInterval. Before the flush triggers, if we add some documents they are marked as sucess. Need an alternate approach or suggestions for fixing error metrics

Documentation: No added documentation

Copy link

linux-foundation-easycla bot commented Jun 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lalith47 / name: Lalith Niddapu (73c93dc)

@lalith47 lalith47 force-pushed the fix-elasticsearch-exporter-bulkindexer branch from cdc35b0 to 73c93dc Compare July 1, 2024 14:24
@carsonip
Copy link
Contributor

carsonip commented Jul 2, 2024

If I understand correctly, this is the same issue described in #32377, and #32632 is an attempt to resolve it.

@lalith47
Copy link
Author

lalith47 commented Jul 2, 2024

Hey @carsonip, Thanks for letting me know. I was also doing similar analysis.
We can close this PR as #32632 solves the actual problem.

@lalith47 lalith47 closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants