[exporter/datadog]: improve mappings for span kind dd span type #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure what's going on w/the failing build, failing tests look unrelated |
mx-psi
requested changes
May 11, 2021
| kindWeb string = "web" | ||
| kindCustom string = "custom" | ||
| kindCache string = "cache" | ||
| kindMemcached string = "memcached" |
There was a problem hiding this comment.
memcached is not on the spec list, open a follow up PR to add it? https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#connection-level-attributes
There was a problem hiding this comment.
sounds good, made a pr here open-telemetry/opentelemetry-specification#1689
mx-psi
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR Adds some additional mappings between opentelemetry span kind and datadog span type, that allow users to see more specialized UIs and representation of traces properly marked
dborcachewhereas previously they were allcustomLink to tracking Issue:
Testing: updated unit tests
Documentation: